Support FD_CLOEXEC for server and client sockets created by SocketServer - #604
Merged
bsergean merged 1 commit intoAug 17, 2026
Conversation
This adds a method setCloseOnExec() to enable setting FD_CLOEXEC on the server and client file descriptors before starting to listen or initiating the WebSocket handshake. This is useful if a process spawns child processes via system() or otherwise, but does not want have WebSocket specific sockets to be inherited to child processes.
awelzel
force-pushed
the
topic/awelzel/set-close-on-exec-socket-server
branch
from
August 17, 2026 09:07
4f7df1c to
52b9e87
Compare
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method setCloseOnExec() to enable setting FD_CLOEXEC on the server and client file descriptors before starting to listen or initiating the WebSocket handshake. This is useful if a process spawns child processes via system() or otherwise, but does not want have WebSocket specific sockets to be inherited to child processes.